Skip to content

Leave the unread bar out of the message count for screen readers #31218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rezabakhshilaktasaraei wants to merge 2 commits into
base: dev
Choose a base branch
from
+54 −0
Open

Leave the unread bar out of the message count for screen readers #31218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c3af2e4
Expose the unread bar as a separator to screen readers
rezabakhshilaktasaraei Aug 31, 2026
31c0ebb
Leave the unread bar out of the message count for screen readers
rezabakhshilaktasaraei Sep 1, 2026
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions Telegram/SourceFiles/history/history_inner_widget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6625,6 +6625,30 @@ QAccessible::Role HistoryInner::accessibilityChildRole() const {
return QAccessible::Role::ListItem;
}

QAccessible::Role HistoryInner::accessibilityChildRoleAt(int index) const {
// The unread bar divides the read messages from the unread ones, it
// is not a message itself - a separator to a screen reader, which also
// keeps it out of the selection and the item count.
const auto barIndex = accessibilityUnreadBarIndex();
return (barIndex >= 0 && index == barIndex)
? QAccessible::Role::Separator
: accessibilityChildRole();
}

Ui::AccessibilitySetPosition HistoryInner::accessibilityChildSetPosition(
int index) const {
// The unread bar is not one of the messages: it has no position of its
// own and does not count, so the messages below it are not shifted.
const auto count = accessibilityChildCount();
const auto barIndex = accessibilityUnreadBarIndex();
if (barIndex < 0) {
return { index + 1, count };
} else if (index == barIndex) {
return {};
}
return { (index > barIndex) ? index : (index + 1), count - 1 };
}

QRect HistoryInner::accessibilityChildRect(int index) const {
const auto barIndex = accessibilityUnreadBarIndex();
if (barIndex >= 0 && index == barIndex) {
Expand Down
3 changes: 3 additions & 0 deletions Telegram/SourceFiles/history/history_inner_widget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,6 +128,9 @@ class HistoryInner
QString accessibilityChildName(int index) const override;
QAccessible::State accessibilityChildState(int index) const override;
QAccessible::Role accessibilityChildRole() const override;
QAccessible::Role accessibilityChildRoleAt(int index) const override;
Ui::AccessibilitySetPosition accessibilityChildSetPosition(
int index) const override;
QRect accessibilityChildRect(int index) const override;
int accessibilityChildColumnCount(int row) const override;
QAccessible::Role accessibilityChildSubItemRole() const override;
Expand Down
24 changes: 24 additions & 0 deletions Telegram/SourceFiles/history/view/history_view_list_widget.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6282,6 +6282,30 @@ QAccessible::Role ListWidget::accessibilityChildRole() const {
return QAccessible::Role::ListItem;
}

QAccessible::Role ListWidget::accessibilityChildRoleAt(int index) const {
// The unread bar divides the read messages from the unread ones, it
// is not a message itself - a separator to a screen reader, which also
// keeps it out of the selection and the item count.
const auto barIndex = accessibilityUnreadBarIndex();
return (barIndex >= 0 && index == barIndex)
? QAccessible::Role::Separator
: accessibilityChildRole();
}

Ui::AccessibilitySetPosition ListWidget::accessibilityChildSetPosition(
int index) const {
// The unread bar is not one of the messages: it has no position of its
// own and does not count, so the messages below it are not shifted.
const auto count = accessibilityChildCount();
const auto barIndex = accessibilityUnreadBarIndex();
if (barIndex < 0) {
return { index + 1, count };
} else if (index == barIndex) {
return {};
}
return { (index > barIndex) ? index : (index + 1), count - 1 };
}

QRect ListWidget::accessibilityChildRect(int index) const {
const auto barIndex = accessibilityUnreadBarIndex();
if (barIndex >= 0 && index == barIndex) {
Expand Down
3 changes: 3 additions & 0 deletions Telegram/SourceFiles/history/view/history_view_list_widget.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -565,6 +565,9 @@ class ListWidget final
QString accessibilityChildName(int index) const override;
QAccessible::State accessibilityChildState(int index) const override;
QAccessible::Role accessibilityChildRole() const override;
QAccessible::Role accessibilityChildRoleAt(int index) const override;
Ui::AccessibilitySetPosition accessibilityChildSetPosition(
int index) const override;
QRect accessibilityChildRect(int index) const override;
int accessibilityChildColumnCount(int row) const override;
QAccessible::Role accessibilityChildSubItemRole() const override;
Expand Down
Loading