Leave the unread bar out of the message count for screen readers - #31218
Open
rezabakhshilaktasaraei wants to merge 2 commits into
Open
Leave the unread bar out of the message count for screen readers#31218rezabakhshilaktasaraei wants to merge 2 commits into
rezabakhshilaktasaraei wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #31211 and builds on top of it: that PR exposes the unread bar as a separator, this one keeps it out of the "x of y" a screen reader announces for the messages around it.
With desktop-app/lib_ui#359 a painted list item reports its position within its set, by default its index among all rows. The unread bar is not a message, so both message lists override that: the bar itself reports no position, and the messages are numbered without counting it, so the first unread message is "5 of 20" whether or not the bar sits above it.
Needs desktop-app/lib_ui#359 (and desktop-app/patches#265 for the Qt side of it).
Tested with NVDA on Windows 10: arrowing through a chat with unread messages announces every message with its number and the total, the numbers do not skip across the bar, and the bar is still announced as "Unread messages, separator" with no position of its own.