Speed up app startup (cache Webview::Availability)#30314
Open
futpib wants to merge 1 commit intotelegramdesktop:devfrom
Open
Speed up app startup (cache Webview::Availability)#30314futpib wants to merge 1 commit intotelegramdesktop:devfrom
futpib wants to merge 1 commit intotelegramdesktop:devfrom
Conversation
ilya-fedin
approved these changes
Feb 19, 2026
Contributor
ilya-fedin
left a comment
ilya-fedin
left a comment
There was a problem hiding this comment.
~200ms each on Linux
the price of converting async api into a sync one with a nested event loop 😭
Iv::ShowButton() and LocationPicker::Available() each called Webview::Availability() separately (~200ms each on Linux). Replace the per-caller static caches with a single shared cache in Core::CachedWebviewAvailability(), reducing startup from two ~200ms calls to one.
futpib
force-pushed
the
cache-webview-availability
branch
from
12c00bb to
d82bb4f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iv::ShowButton() and LocationPicker::Available() each called Webview::Availability() separately (~200ms each on Linux). Replace the per-caller static caches with a single shared cache in Core::CachedWebviewAvailability(), reducing startup from two ~200ms calls to one.
Previous failed attempt at this: desktop-app/lib_webview#136 + #30310