Speed up app startup (remove redundant cache and pre-warming)#30310
Closed
futpib wants to merge 1 commit intotelegramdesktop:devfrom
Closed
Speed up app startup (remove redundant cache and pre-warming)#30310futpib wants to merge 1 commit intotelegramdesktop:devfrom
futpib wants to merge 1 commit intotelegramdesktop:devfrom
Conversation
Iv::ShowButton() and LocationPicker::Available() each cache the result of Webview::Availability() in a static local. These caches are redundant since desktop-app/lib_webview#136 adds internal caching to Availability() itself. Remove the per-caller static caches and the pre-warming calls in Application::run() that existed only to populate them early.
ilya-fedin
reviewed
Feb 18, 2026
| // Create mime database, so it won't be slow later. | ||
| QMimeDatabase().mimeTypeForName(u"text/plain"_q); | ||
|
|
||
| // Check now to avoid re-entrance later. |
Contributor
There was a problem hiding this comment.
You're returning re-entrance. That's critical, the app is going to crash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iv::ShowButton() and LocationPicker::Available() each cache the result of Webview::Availability() in a static local.
These caches will be redundant if/when desktop-app/lib_webview#136 is merged.
TLDR: look at desktop-app/lib_webview#136 first
A better idea: desktop-app/lib_webview#136 (comment)