Skip to content

Add math.cbrt() and math.exp2() #1271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jseop-lim wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add math.cbrt() and math.exp2() #1271

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions graalpython/com.oracle.graal.python.test/src/tests/unittest_tags/test_math.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ test.test_math.MathTests.testAsinh @ darwin-arm64,linux-aarch64,linux-aarch64-gi
test.test_math.MathTests.testAtan @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_math.MathTests.testAtan2 @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_math.MathTests.testAtanh @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_math.MathTests.testCbrt @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_math.MathTests.testCeil @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_math.MathTests.testComb @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_math.MathTests.testConstants @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
Expand All @@ -32,6 +33,7 @@ test.test_math.MathTests.testCosh @ darwin-arm64,linux-aarch64,linux-aarch64-git
test.test_math.MathTests.testDegrees @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_math.MathTests.testDist @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_math.MathTests.testExp @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_math.MathTests.testExp2 @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_math.MathTests.testFabs @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_math.MathTests.testFactorial @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
test.test_math.MathTests.testFactorialNonIntegers @ darwin-arm64,linux-aarch64,linux-aarch64-github,linux-x86_64,linux-x86_64-github,win32-AMD64,win32-AMD64-github
Expand Down
34 changes: 34 additions & 0 deletions ....oracle.graal.python/src/com/oracle/graal/python/builtins/modules/MathModuleBuiltins.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,22 @@ private static double compute(Node inliningTarget, double value, PRaiseNode rais
}
}

@Builtin(name = "cbrt", minNumOfPositionalArgs = 1, doc = "Return the cube root of x.")
@GenerateNodeFactory
public abstract static class CbrtNode extends PythonUnaryBuiltinNode {

@Specialization
static double doGeneric(VirtualFrame frame, Object value,
@Bind Node inliningTarget,
@Cached MathUnaryHelperNode helperNode) {
return helperNode.execute(frame, inliningTarget, value, CbrtNode::compute);
}

private static double compute(Node inliningTarget, double value, PRaiseNode raiseNode) {
return Math.cbrt(value);
}
}

@Builtin(name = "exp", minNumOfPositionalArgs = 1)
@GenerateNodeFactory
public abstract static class ExpNode extends PythonUnaryBuiltinNode {
Expand All @@ -273,6 +289,24 @@ private static double compute(Node inliningTarget, double value, PRaiseNode rais
}
}

@Builtin(name = "exp2", minNumOfPositionalArgs = 1, doc = "Return 2 raised to the power of x.")
@GenerateNodeFactory
public abstract static class Exp2Node extends PythonUnaryBuiltinNode {

@Specialization
static double doGeneric(VirtualFrame frame, Object value,
@Bind Node inliningTarget,
@Cached MathUnaryHelperNode helperNode) {
return helperNode.execute(frame, inliningTarget, value, Exp2Node::compute);
}

private static double compute(Node inliningTarget, double value, PRaiseNode raiseNode) {
double result = Math.pow(2.0, value);
checkMathRangeError(Double.isFinite(value) && Double.isInfinite(result), inliningTarget, raiseNode);
return result;
}
}

@Builtin(name = "expm1", minNumOfPositionalArgs = 1)
@GenerateNodeFactory
public abstract static class Expm1Node extends PythonUnaryBuiltinNode {
Expand Down