Repository navigation
Conversation
Both functions were added to the math module in Python 3.11 and were missing, so math.cbrt and math.exp2 raised AttributeError. cbrt uses Math.cbrt; exp2 uses Math.pow(2.0, x) and raises OverflowError on an infinite result from a finite argument, as exp does. Enable CPython's testCbrt and testExp2, which now pass. Signed-off-by: Jeongseop Lim <jeongseop_lim@korea.ac.kr>
oracle-contributor-agreement
Bot
added
the
OCA Verified
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1260
math.cbrtandmath.exp2, added in Python 3.11, were missing from themathmodule. CPython defines both asmath_1wrappers over libm, with overflow checking forexp2only (mathmodule.c#L1113-L1115,#L1174-L1176).AS-IS
TO-BE
(matching CPython)
Changes
CbrtNode, returningMath.cbrt(value).Exp2Node, returningMath.pow(2.0, value)with the same range check asExpNode.test.test_math.MathTests.testCbrtandtestExp2inunittest_tags/test_math.txt.Testing
mx python-jvmon darwin-aarch64, then--tagged test_math(81 passed; master passes 79). Eighteencbrtandexp2calls, including infinities, NaN,-0.0and the overflow case, return the same values as CPython 3.13.14.