The Wayback Machine - https://web.archive.org/web/20151231184436/https://code.google.com/p/chromium/issues/detail?id=64470
My favorites | Sign in
Project Home Downloads Wiki Issues Code Search
Issue 64470: WebSocket: Implement new WebSocket protocol
22 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  yutak@chromium.org
Closed:  Jul 2011
Cc:  tyoshino@chromium.org, ukai@chromium.org, toyoshim@chromium.org

Restricted
  • Only users with EditIssue permission may comment.


Sign in to add a comment
 
Project Member Reported by yutak@chromium.org, Nov 25, 2010
http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-03

This will cause (intentional) compatibility break with older servers.
Dec 9, 2010
#2 kerz@chromium.org
P2 bugs with an owner that are not marked as started are being automatically moved to mstone:11.
Labels: -Mstone-10 MovedFrom-10 Mstone-11
Feb 28, 2011
#3 yutak@chromium.org
Punting to M-12, as protocol discussion is still ongoing in IETF hybi list.
Summary: WebSocket: Implement new WebSocket protocol
Labels: -Mstone-11 Mstone-12
Mar 2, 2011
#4 arturczajka@gmail.com
In the mean time:
http://tools.ietf.org/html/draft-ietf-hybi-thewebsocketprotocol-06
I'm posting it just for the record as I believe anyone interested is up-to-date.
Can't wait for version 12 to hit the chrome-dev channel ;)

BTW - is there a simple, built-in way to check which protocol version is implemented in the browser I'm using (chrome 11.0.686.1)?
Mar 2, 2011
#5 toyoshim@chromium.org
(No comment was entered for this change.)
Cc: -toyos...@google.com toyos...@chromium.org
Apr 15, 2011
#6 yutak@chromium.org
This is going to be in M-13.
Labels: -Mstone-12 Mstone-13
May 6, 2011
#7 bugdroid1@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=84427

------------------------------------------------------------------------
r84427 | yutak@chromium.org | Fri May 06 03:14:28 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/websockets/websocket_handshake_handler.cc?r1=84427&r2=84426&pathrev=84427
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/websockets/websocket_job.cc?r1=84427&r2=84426&pathrev=84427
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/websockets/websocket_handshake_handler_unittest.cc?r1=84427&r2=84426&pathrev=84427
 M http://src.chromium.org/viewvc/chrome/trunk/src/net/websockets/websocket_handshake_handler.h?r1=84427&r2=84426&pathrev=84427

Accept new WebSocket handshake format (hybi-04 and later).

To update WebSocket protocol implementation in WebKit,
WebSocketRequestHandshakeHandler and WebSocketResponseHandler need to be able
to understand both old handshake (hybi-03 and prior, including hixie-76) and
new handshake (hybi-04 and later).

BUG=64470
TEST=net_unittests --gtest_filter="WebSocketHandshake*HandlerTest.*"


Review URL: http://codereview.chromium.org/6823075
------------------------------------------------------------------------
May 30, 2011
#9 fre...@gmail.com
Working on a Mojolicious site that supports ietf-07 (hybi-07?) but chrome doesn't appear to co-operate - The server registers the websocket connection but chrome never completes the connection it seems.

I'm using "13.0.781.0 (Developer Build 87259 Linux)" which I downloaded today - there are no warnings or errors which make this any easier to diagnose.

Knowing what version of the protocol Chrome supports (and getting a console error/warning) would be extremely useful

May 30, 2011
#10 yutak@google.com
The new protocol is not implemented yet. Hixie's draft 76 is what we support right now.
May 30, 2011
#11 ukai@chromium.org
To diagnose, you can use chrome://net-internals/#events, and filter by "ws" or target url. you'll see what handshake request chrome sent and what handshake response chrome received.

Jun 2, 2011
#12 lafo...@chromium.org
Moving !type=meta|regression and !releaseblocker to next mstone
Labels: -Mstone-13 Mstone-14 MovedFrom-13
Jul 12, 2011
#13 pimvande...@gmail.com
I am wondering whether and when the hybi-07 will be implemented so that Chrome sends  handshakes in that new format. Is there any hint as to when this might be implemented?
Jul 12, 2011
#14 toyoshim@chromium.org
FYI, the latest one is hybi-10.

Jul 22, 2011
#15 bugdroid1@chromium.org
The following revision refers to this bug:
    http://src.chromium.org/viewvc/chrome?view=rev&revision=93578

------------------------------------------------------------------------
r93578 | yutak@chromium.org | Fri Jul 22 01:24:47 PDT 2011

Changed paths:
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.h?r1=93578&r2=93577&pathrev=93578
 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpreferences.cc?r1=93578&r2=93577&pathrev=93578
 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/extensions/api_test/websocket/test.html?r1=93578&r2=93577&pathrev=93578
 M http://src.chromium.org/viewvc/chrome/trunk/src/content/worker/test/worker_uitest.cc?r1=93578&r2=93577&pathrev=93578

Enable hybi WebSocket protocol by default.

This CL enables the new WebSocket protocol by overriding the value of WebCore::Settings::useHixie76WebSocketProtocol() to false.

It is known that WebSocket instances initialized in worker context use the old hixie76 protocol even after this change is applied (see https://bugs.webkit.org/show_bug.cgi?id=64852). I'm going to take care of it after this CL is committed.

BUG=64470
TEST=none


Review URL: http://codereview.chromium.org/7462009
------------------------------------------------------------------------
Jul 27, 2011
#16 kerz@google.com
Punting out non-critical bugs.  Please move back to 14 if you believe this was done in error.
Labels: -Mstone-14 Mstone-15 MovedFrom-14
Jul 28, 2011
#17 yutak@chromium.org
Actually, hybi-10 handshake and framing is implemented and will be shipped with M14.
Status: Fixed
Labels: -Feature-WebSocket -Mstone-15 -MovedFrom-14 WebKit-WebSockets Mstone-14
Oct 12, 2012
#18 bugdroid1@chromium.org
This issue has been closed for some time. No one will pay attention to new comments.
If you are seeing this bug or have new data, please click New Issue to start a new bug.
Labels: Restrict-AddIssueComment-Commit
Mar 10, 2013
#19 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Area-WebKit -WebKit-WebSockets -WebKit-Core -Mstone-14 Cr-Content Cr-Content-WebSockets Cr-Content-Core M-14
Mar 13, 2013
#20 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Restrict-AddIssueComment-Commit Restrict-AddIssueComment-EditIssue
Apr 5, 2013
#21 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Cr-Content Cr-Blink
Apr 5, 2013
#22 bugdroid1@chromium.org
(No comment was entered for this change.)
Labels: -Cr-Content-WebSockets Cr-Blink-WebSockets
Nov 26, 2015
#23 tkent@chromium.org
(No comment was entered for this change.)
Labels: Cr-Blink-Network-WebSockets
Nov 26, 2015
#24 tkent@chromium.org
(No comment was entered for this change.)
Labels: -Cr-Blink-WebSockets
Sign in to add a comment

Powered by Google Project Hosting