This repository was archived by the owner on Oct 25, 2023. It is now read-only.
Open
Conversation
Author
|
Actually now that I'm actually taking time to read the gulpfile I'm thinking I might not need to add that since it just puts those files into the top level when you build. I'll await confirmation on whether or not I need to do anything there. Also, since I forgot to mention this in the initial PR description, I also stopped the badge/title from flashing since it's unnecessary when the badge is there, and if anything would be kinda distracting with a red dot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently started using Telegram, and it's pretty good but I was getting a bit frustrated with the unread favicon indicator in the webapp. Most other chat webapps I use make it a little more obvious when you have a notification, whereas Telegram just has a mail icon with the same color scheme.
I did some Googling and found I was not the only one with this problem:
#1585
#1718
So this PR hopefully solves this issue! I was originally just gonna make it a red dot, but I saw in the one issue someone mentioned adding a count to the badge, so I figured I might as well do that while I'm messing around here.
Here's a picture of what it looks like in a tab:

Let me know if something needs fixing!