[sadym-chromium]

Closes #146

The following tasks have been completed:

• Modified Web platform tests ([Gecko Bug 1954992] [wpt] Add support for "emulation.setGeolocationOverride" command to bidi client. web-platform-tests/wpt#51896)

Implementation commitment (and no objections):

• WebDriver BiDi (Emulation: Support geolocation override webdriver-bidi#343)
• WebKit (https://bugs.webkit.org/show_bug.cgi?id=291197)
• Chromium (https://bugs.chromium.org/p/chromium/issues/detail?id=407577194)
• Gecko (https://bugzilla.mozilla.org/show_bug.cgi?id=1954992)

Documentation (new feature):

• [ ] Updated implementation report N/A
• [ ] Pinged MDN N/A. will be exposed via WebDriver BiDi
• [ ] Added example to README or spec N/A. will be exposed via WebDriver BiDi

For documentation, either create an issue or pull request in MDN's Content repo - providing as much information as you can. PR is prefered.

---

Preview | Diff

[jgraham]

At a high level this looks right to me (i.e. I think it matches the WebDriver API in which you provide either a full set of overrides, or null).

[reillyeon]

As a general comment, please add the markup to indicate that these changes are "Candidate Additions". See the existing annotations in the spec for examples.

[sadym-chromium]

As a general comment, please add the markup to indicate that these changes are "Candidate Additions". See the existing annotations in the spec for examples.

done

[sadym-chromium]

Converting for draft to wait for the webdriver-bidi specification and corresponding WPT tests are landed.

[sadym-chromium]

Webdriver-bidi is landed.

[reillyeon]

In the "implementation commitment" section above, shouldn't we still make sure that browsers are committed to implementing the new WebDriver BiDi commands?

[reillyeon]

This change looks good to me, however we still need to get implementation commitment signals from browser engines. Assuming no engine has already implemented the new WebDriver BiDi commands, please file issues for each engine and update the PR template with links to them.

[sadym-chromium]

This change looks good to me, however we still need to get implementation commitment signals from browser engines. Assuming no engine has already implemented the new WebDriver BiDi commands, please file issues for each engine and update the PR template with links to them.

done

[reillyeon]

Why is WebKit marked "N/A"?

[sadym-chromium]

Why is WebKit marked "N/A"?

I'm not aware of WebKit's commitment of supporting geolocation emulation, so I marked it as N/A. I guess the proper way to signal it is just to unmark the checkbox, which I just did.

[reillyeon]

Please file an issue against WebKit so we can get signals directly from the team. Or maybe @marcoscaceres can comment here.

[sadym-chromium]

Please file an issue against WebKit so we can get signals directly from the team. Or maybe @marcoscaceres can comment here.

done

[lutien]

The web platform tests have been merged to WPT repo: web-platform-tests/wpt#51896 (comment).

[sadym-chromium]

@reillyeon do you think we have any other blockers?

[reillyeon]

It looks like we have consensus from Blink and Gecko. @marcoscaceres, can you ask someone from WebKit to take a look? I'm comfortable merging this now as a candidate addition given current interest signals.