Repository navigation
Conversation
…r that owns the property vimeo#7766 For `I<string>&Box<int>` the owning class was resolved to Box, but Box's templates were substituted with I's type params. Take the type params of the intersection member that matches the resolved class, on both the property write and read paths.
…template intersections vimeo#7766
alies-dev
marked this pull request as ready for review
November 1, 2026 10:09
Contributor
✅ Performance: unchanged · Issues: decreased
How to read this table
✅ laravel: issues +3 −5Memory 1 906 → 1 907 MB (+0.1 %) · Wall 113.7 → 117.2 s (+3.1 %) Weighted 51 781 → 51 777 (−4, −0.01 %): L1 −1 · L3 +1 · L4 −3 · L6 +1
Added (3)
Removed (5)
head 6b2a3a0 · base 84a5953 (merge-base) · workflow run |
…e-generic-type-in-magic-property-in-trait # Conflicts: # tests/Template/ClassTemplateExtendsTest.php # tests/Template/ClassTemplateTest.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Template types in
@property/@property-writedeclared on a trait or parent class are not mapped through@use/@extends, and@property-writetypes are never localized to the receiver's type params.Before
After
Intersection receivers take the wrong class's type params
For
I<string>&Box<int>, property types ofBox(real and magic, read and write) were localized withI's type params.Before
After
Template intersection constraints are dropped through
@extends/@useBefore
After
Fixes #7766