Repository navigation
fix: exclude non-prefetchable cache entries from RDC - #101004
Open
ahmedgabrrr wants to merge 1 commit into
Open
ahmedgabrrr wants to merge 1 commit into
ahmedgabrrr wants to merge 1 commit into
Conversation
ahmedgabrrr
force-pushed
the
fix/use-cache-stale-rdc
branch
from
October 31, 2026 15:48
15fba50 to
468c338
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where non-prefetchable cache entries were still being included in the Resume Data Cache (RDC), even though they were already excluded from the prerendered result.
The issue happened because the RDC serializer wasn't checking the stale value against MIN_PREFETCHABLE_STALE.
I've updated the serializer to exclude these entries as well, keeping its behavior consistent with the prerendering logic.
Testing
Added an E2E regression test for non-prefetchable cache entries.
Verified that the test fails without the fix and passes after applying it.
Ran the use-cache E2E test suite in start mode (59 tests passed).
Fixes #100982