Repository navigation
Conversation
Co-authored-by: Niklas Mischkulnig <4586894+mischnic@users.noreply.github.com> Co-authored-by: Tobias Koppers <1365881+sokra@users.noreply.github.com>
Contributor
Tests PassedCommit: 3430a80 |
mischnic
marked this pull request as ready for review
October 30, 2026 22:42
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Add turbo_tasks agent guidance for eventual consistency and cell equality.
Why?
#100928 showed that separately published cells can be read from different executions during recomputation, causing cross-cell index lookups to panic. #100935 showed a distinct, persistent mismatch: order-insensitive equality can retain an old collection ordering while related indices change.
How?
Document safe handling of mixed-generation reads, the distinction between bounds guards and coherent snapshots, and the need for equality to capture observable ordering. Keep the guidance in the existing shared turbo_tasks section of
turbopack/AGENTS.md, already referenced bycrates/AGENTS.md, without duplicating instructions.Verification
turbopack/AGENTS.mdis modified.