Repository navigation
Conversation
teidesu
force-pushed
the
scroll-perf-fixes
branch
from
July 22, 2026 23:55
e82a618 to
bfb680a
Compare
Contributor
Author
|
removed subpixel scrolling related changes as per desktop-app/lib_ui#324 (comment) keeping the async decoding fixes still |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
an attempt to make scrolling the chat history smoother on macos. two parts: render scroll positions with sub-pixel precision (needs desktop-app/lib_ui#324), and stop decoding images on the main thread, which caused visible stutter while scrolling media-heavy chats. it's not perfect but noticeably smoother.
generateThumbnailBytesflag.checkStickerLargeconstructed theImage(synchronous decode) on the main thread; move the decode tocrl::asyncwith a loading guard.FileLoadernow also decodespartial:-prefixed cache entries off-thread when the partial data covers the requested size, and decodes freshly downloaded images oncrl::asyncbefore firing updates instead of leaving it to the consumer on the main thread.HistoryInnersubscribes to the scroll view's sub-pixel offset, translates painting by the fraction (keeping the floating date badge and forum bar pinned) and compensates in all hit-testing paths.note: the code in this pr was written partially by claude fable 5 and partially by gpt-5.6-sol.