Rename accessibility lang keys to lng_sr_ prefix#30350
Closed
rezabakhshilaktasaraei wants to merge 1 commit intotelegramdesktop:devfrom
Closed
Rename accessibility lang keys to lng_sr_ prefix#30350rezabakhshilaktasaraei wants to merge 1 commit intotelegramdesktop:devfrom
rezabakhshilaktasaraei wants to merge 1 commit intotelegramdesktop:devfrom
Conversation
Rename all accessibility-related lang keys to use the lng_sr_ prefix for consistency with the screen reader naming convention.
rezabakhshilaktasaraei
force-pushed
the
fix/rename-accessibility-lang-keys
branch
from
3b0461a to
4e7852c
Compare
Member
|
Renaming is not a good idea after phrases land on the cloud translation platform, this will just cancel existing translations usage and double the added keys on the platform till the old ones will be manually deleted, which shouldn't happen fast, because they're used in deployed versions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lng_tolng_sr_prefix for consistency with the screen reader naming convention established in recent accessibility PRs.Renamed keys:
lng_main_menu→lng_sr_main_menulng_filter_unread_chats→lng_sr_filter_unread_chatslng_minimize_window→lng_sr_minimize_windowlng_maximize_window→lng_sr_maximize_windowlng_restore_window→lng_sr_restore_windowlng_go_back→lng_sr_go_backlng_phone_number→lng_sr_phone_numberlng_settings_scale→lng_sr_settings_scaleTest plan