Speed up app startup (defer sticker reads via InvokeQueued)#30308
Open
futpib wants to merge 1 commit intotelegramdesktop:devfrom
Open
Speed up app startup (defer sticker reads via InvokeQueued)#30308futpib wants to merge 1 commit intotelegramdesktop:devfrom
futpib wants to merge 1 commit intotelegramdesktop:devfrom
Conversation
Instead of reading all sticker sets synchronously in crl::on_main, chain each read step via InvokeQueued so that paint events can be processed between heavy file reads. This moves first paint from ~2807ms to ~1294ms by allowing the UI to render before sticker loading completes.
futpib
force-pushed
the
defer-sticker-reads
branch
from
b05d438 to
7d04ce3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of reading all sticker sets synchronously in crl::on_main, chain each read step via InvokeQueued so that paint events can be processed between heavy file reads. This moves first paint from ~2807ms to ~1294ms in my tests by allowing the UI to render before sticker loading completes.
I checked it locally with a bunch of
PROFILE_LOGs: https://github.com/telegramdesktop/tdesktop/compare/dev...futpib:faster-startup?expand=1I also considered making this
InvokeQueuedqueue an util inlib_base, tell me if you prefer that.