Add screen reader support for language list#30304
Open
rezabakhshilaktasaraei wants to merge 1 commit intotelegramdesktop:devfrom
Open
Add screen reader support for language list#30304rezabakhshilaktasaraei wants to merge 1 commit intotelegramdesktop:devfrom
rezabakhshilaktasaraei wants to merge 1 commit intotelegramdesktop:devfrom
Conversation
5 tasks
b517bd4 to
2cc5910
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exposes painted language rows in the language selection box as virtual accessibility children, making the list navigable by screen readers.
Changes (
language_box.cpp)accessibilityChildCount(),accessibilityChildName(),accessibilityChildRect(),accessibilityChildState(), andaccessibilityChildRole()on the inner widget.ListItemaccessible child.selectedstate.accessibilityChildFocused()when selection changes via keyboard.focusInEvent.Dependencies
Accessible::Iteminfrastructure.No new lang keys
Uses only existing
lng_*keys — no new strings added.Test plan