Improve scheduling objects deletion - #249
Merged
Merged
Conversation
tchapi
force-pushed
the
cc/fix-scheduling-objects-deletion
branch
2 times, most recently
from
March 7, 2026 21:34
3388090 to
bfe718b
Compare
tchapi
commented
Mar 7, 2026
Comment on lines
-40
to
+47
| } else { | ||
| // Returns CalendarInstances as objects | ||
| return $query->getQuery() | ||
| ->getResult(); | ||
| } | ||
|
|
||
| // Returns CalendarInstances as objects | ||
| return $query->getQuery() | ||
| ->getResult(); |
tchapi
commented
Mar 7, 2026
Comment on lines
-86
to
+102
| $objectRepository = $this->getEntityManager()->getRepository(\App\Entity\CalendarObject::class); | ||
| $objectRepository = $this->getEntityManager()->getRepository(CalendarObject::class); |
tchapi
commented
Mar 7, 2026
Comment on lines
-98
to
+116
| \App\Entity\Calendar::COMPONENT_EVENTS => 'events', | ||
| \App\Entity\Calendar::COMPONENT_NOTES => 'notes', | ||
| \App\Entity\Calendar::COMPONENT_TODOS => 'tasks', | ||
| Calendar::COMPONENT_EVENTS => 'events', | ||
| Calendar::COMPONENT_NOTES => 'notes', | ||
| Calendar::COMPONENT_TODOS => 'tasks', |
Closed
tchapi
force-pushed
the
cc/fix-scheduling-objects-deletion
branch
from
March 21, 2026 19:03
6a41908 to
29b2d5a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.