Add an auto remove duplicates for the playlists.

[Vinzzzze]

When adding tracks to a playlist, you may have tracks in flac format for quality and mp3 format for portable devices, so when you select an album from the library to add to the playlist the flac and the mp3 will be added.
You can use the remove duplicates menu on the playlist, but if you want to have some tracks more than one time in your playlist, it will also delete theses tracks...
So I add the opportunity to automatically delete the duplicates in the added track list.

In the parameters, playlist tab, I add a checkbox to remove the added duplicates.
The data is then forwarded to the playlist object, when tracks are inserted in the playlist (Playlist::InsertSongItems), if the functionality is on, the duplicates are removed (call Playlist::RemoveDuplicateSongs)
Playlist::RemoveDuplicateSongs had been change to work on any track list, not only the playlist's tracklist.

Summary by CodeRabbit

• New Features
  • Added a configurable “Remove duplicates when adding tracks to the playlist” option in playlist settings.
  • When enabled, duplicate songs are filtered out automatically during track insertion, including batch additions.
  • The preference is persisted and applied to both regular and smart playlist previews.
  • Player settings reload now recognizes the option immediately, without needing a restart.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

📝 Walkthrough

Walkthrough

Adds a persistent remove-duplicates playlist setting and wires it through the settings UI, playlist construction and insertion, playlist manager state, and runtime settings reload.

Changes

Remove Duplicates Playlist Feature

Layer / File(s)	Summary
Settings constant and UI checkbox src/constants/playlistsettings.h, src/settings/playlistsettingspage.ui, src/settings/playlistsettingspage.cpp	Adds kRemoveDuplicates, adds checkbox_remove_duplicates to the playlist settings page, and loads/saves the checkbox state.
Playlist API structure and declarations src/playlist/playlist.h	Adds the default constant, constructor parameter, setting updater, helper declarations, duplicate-removal overloads, row-removal overloads, and remove_duplicates_.
Playlist implementation and duplicate removal flow src/playlist/playlist.cpp	Stores the flag, deduplicates insertion batches when enabled, and applies row removal to the analyzed item list.
PlaylistManager state and propagation src/playlist/playlistmanager.h, src/playlist/playlistmanager.cpp	Adds the manager flag and getter, propagates updates to loaded playlists, and passes the flag to new playlists.
Player settings reload and smart playlist wiring src/core/player.cpp, src/smartplaylists/smartplaylistsearchpreview.cpp	Reloads the setting into PlaylistManager and passes the current flag into smart playlist preview construction.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Poem

🐇 Hoppity-hop, a checkbox now gleams,
No duplicate tracks in playlist dreams.
One flag to set, one path to share,
Songs land once, with bunny care.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 8.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: adding automatic duplicate removal for playlists.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

src/core/player.cpp (1)

154-154: ⚡ Quick win

Use a single source of truth for the remove-duplicates default.

Line [154] uses a literal false; prefer REMOVE_DUPLICATES_DEFAULT to prevent default drift across layers.

Suggested change

-  playlist_manager_->update_setting(s.value(PlaylistSettings::kRemoveDuplicates, false).toBool());
+  playlist_manager_->update_setting(s.value(PlaylistSettings::kRemoveDuplicates, REMOVE_DUPLICATES_DEFAULT).toBool());

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/core/player.cpp` at line 154, The hardcoded literal `false` in the
`playlist_manager_->update_setting()` call at line 154 should be replaced with
the constant `REMOVE_DUPLICATES_DEFAULT` to maintain a single source of truth
for the remove-duplicates default value across all layers of the codebase. This
prevents default drift if the constant is updated in the future.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/core/player.cpp`:
- Line 154: The hardcoded literal `false` in the
`playlist_manager_->update_setting()` call at line 154 should be replaced with
the constant `REMOVE_DUPLICATES_DEFAULT` to maintain a single source of truth
for the remove-duplicates default value across all layers of the codebase. This
prevents default drift if the constant is updated in the future.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e48fa2bd-ae4f-4f54-8324-b76af366da01

📥 Commits

Reviewing files that changed from the base of the PR and between de3ad29 and 3539075.

📒 Files selected for processing (9)

• src/constants/playlistsettings.h
• src/core/player.cpp
• src/playlist/playlist.cpp
• src/playlist/playlist.h
• src/playlist/playlistmanager.cpp
• src/playlist/playlistmanager.h
• src/settings/playlistsettingspage.cpp
• src/settings/playlistsettingspage.ui
• src/smartplaylists/smartplaylistsearchpreview.cpp