Add a sub-menu to the shuffle playlist menu to decide how to shuffle. - #2037
Open
Vinzzzze wants to merge 1 commit into
Open
Add a sub-menu to the shuffle playlist menu to decide how to shuffle.#2037Vinzzzze wants to merge 1 commit into
Vinzzzze wants to merge 1 commit into
Conversation
Vinzzzze
force-pushed
the
shuffle_playlist
branch
4 times, most recently
from
March 20, 2026 18:24
b67c38c to
37f312f
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
from
March 26, 2026 18:39
37f312f to
547c2bb
Compare
jonaski
reviewed
Mar 29, 2026
Vinzzzze
force-pushed
the
shuffle_playlist
branch
3 times, most recently
from
April 4, 2026 18:36
da0abb6 to
151a5d1
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
3 times, most recently
from
April 10, 2026 19:29
9f20871 to
b40c2ea
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
5 times, most recently
from
April 23, 2026 22:53
7294324 to
32dc249
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
from
April 26, 2026 09:38
32dc249 to
0a876e4
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
3 times, most recently
from
May 10, 2026 21:41
b293551 to
c867763
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
from
May 17, 2026 14:13
c867763 to
46e9772
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
4 times, most recently
from
May 31, 2026 14:47
63f0947 to
e01dd29
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
2 times, most recently
from
June 5, 2026 19:19
0d83afe to
669ccd7
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
2 times, most recently
from
June 13, 2026 18:52
ef4b509 to
59bfc08
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
from
June 15, 2026 13:07
ba28391 to
bf6d7b9
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/playlist/playlist.h`:
- Around line 370-371: The ReshuffleIndices function declaration is missing a
comma between the shuffle_mode parameter and the const bool
album_keep_track_order parameter. Add a comma after shuffle_mode to fix the
syntax error in the parameter list.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 41daddfc-5ae5-49f0-b363-483a4ac1c5fa
📒 Files selected for processing (8)
src/core/mainwindow.cppsrc/core/mainwindow.hsrc/core/mainwindow.uisrc/playlist/playlist.cppsrc/playlist/playlist.hsrc/playlist/playlistmanager.cppsrc/playlist/playlistmanager.hsrc/playlist/playlistmanagerinterface.h
🚧 Files skipped from review as they are similar to previous changes (5)
- src/playlist/playlistmanager.h
- src/playlist/playlistmanagerinterface.h
- src/core/mainwindow.ui
- src/core/mainwindow.h
- src/core/mainwindow.cpp
Vinzzzze
force-pushed
the
shuffle_playlist
branch
2 times, most recently
from
June 21, 2026 14:03
f58a918 to
72d39a8
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
5 times, most recently
from
June 29, 2026 21:13
a2f6091 to
febaf7a
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
2 times, most recently
from
July 5, 2026 15:53
c2c070b to
a1942c3
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
3 times, most recently
from
July 15, 2026 18:32
d388cad to
f12f440
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
4 times, most recently
from
July 26, 2026 15:30
dcd0bd3 to
2a77782
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
3 times, most recently
from
August 2, 2026 12:12
309f2d3 to
eacb7ee
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
3 times, most recently
from
August 12, 2026 18:04
17d1da3 to
4a135ce
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
4 times, most recently
from
August 26, 2026 19:16
0729bae to
cd20a23
Compare
Vinzzzze
force-pushed
the
shuffle_playlist
branch
from
August 29, 2026 14:48
cd20a23 to
eeebd03
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the menu Shuffle playlist (mainwindow ui) to offer three shuffle modes :
Correct what I consider as an issue : when playing a playlist with a mode shuffle grouped, the tracks are played in the order they have in the playlist. Grouped tracks must be played following the track number order.
Update mainwindow for updating the menus
Update playlist to make the ReshuffleIndices reusable for both Reshuffling indices when playing in shuffle mode and when shuffling the playlist from the menu. I left some commented code with a TODO mark for some code linked to another PR to remind me what to do when I will merge one branch in the other.
Update the playlistmanager and it's interface to handle the choice we can now make while shuffling a playlist.
Add the translations for the created menu
Summary by CodeRabbit