Skip to content

GH-8108: Add DSL for Redis Queue Gateways. - #10944

Merged
artembilan merged 4 commits into
spring-projects:mainfrom
mjd507:redis-queue-gateway
Apr 17, 2026
Merged

GH-8108: Add DSL for Redis Queue Gateways.#10944
artembilan merged 4 commits into
spring-projects:mainfrom
mjd507:redis-queue-gateway

Conversation

@mjd507

@mjd507 mjd507 commented Apr 15, 2026

Copy link
Copy Markdown
Contributor

Related to: #8108

doc fix: there are no properties named order and expect-message in queue-inbound-gateway, replaced with phase and extract-payload, modify the properties explanation respectively.
@mjd507
spring-projectsGH-8108: Add DSL for Redis Queue Gateways.
57515a9 
Related to: spring-projects#8108

doc fix: there are no properties named `order` and `expect-message` in queue-inbound-gateway, replaced with `phase` and `extract-payload`, modify the properties explanation respectively.

Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
artembilan
artembilan requested changes Apr 15, 2026
View reviewed changes

@artembilan artembilan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing those docs!

Just couple review concerns to make the code as good as possible.
Comment thread ...ng-integration-redis/src/test/java/org/springframework/integration/redis/dsl/RedisTests.java Outdated
Comment thread ...ng-integration-redis/src/test/java/org/springframework/integration/redis/dsl/RedisTests.java Outdated
Comment thread src/reference/antora/modules/ROOT/pages/redis.adoc Outdated
Comment thread src/reference/antora/modules/ROOT/pages/redis.adoc Outdated
mjd507 added 2 commits April 16, 2026 09:48
@mjd507
Combine queueInboundGateway test and queueOutboundGateway test into o…
95b2d60 
…ne single test.

put reply_channel into the message header for a simpler flow definition.

doc format, one sentence per line.

Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
@mjd507
Remove Spec suffix from all methods in Redis.java, and respective t…
e0d4e66 
…ests and docs.

Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
@mjd507
mjd507 force-pushed the redis-queue-gateway branch from 9979baa to e0d4e66 Compare April 16, 2026 09:06
@mjd507

mjd507 commented Apr 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Sorry, my bad, I just found in Redis.java, I name methods wrongly, all of them should end-with ChannelAdapter or Gateway, not Spec.
last commit fix this!
artembilan
artembilan requested changes Apr 16, 2026
View reviewed changes

@artembilan artembilan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit-pick for the test code!
Comment thread ...ng-integration-redis/src/test/java/org/springframework/integration/redis/dsl/RedisTests.java Outdated
Comment thread ...ng-integration-redis/src/test/java/org/springframework/integration/redis/dsl/RedisTests.java Outdated
@mjd507
Make ReplyChannel as a local variable to be more focused on request-r…
7c2dff6 
…eply pattern.

Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
@artembilan

artembilan commented Apr 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Thank you, it helps me to understand gateways request-reply patterns a little better now.

👍 here is more: https://www.enterpriseintegrationpatterns.com/patterns/messaging/ReturnAddress.html.

make yourself familiar with those patterns and even consider to read that book.

and @cppwfs can even confirm that Enterprise Integration Patterns fit very well into modern AI agentic flows.
@mjd507

mjd507 commented Apr 17, 2026

Copy link
Copy Markdown
Contributor Author

and @cppwfs can even confirm that Enterprise Integration Patterns fit very well into modern AI agentic flows.

I saw his email chainflow using spring-integration and spring-ai, really good 👍
@artembilan artembilan added this to the 7.1.0-RC1 milestone Apr 17, 2026
@artembilan
artembilan merged commit 7ba876b into spring-projects:main Apr 17, 2026
3 checks passed
@mjd507
mjd507 deleted the redis-queue-gateway branch April 18, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment