Skip to content

GH-8108: Add DSL for Redis Outbound Command Gateway. - #10941

Merged
artembilan merged 2 commits into
spring-projects:mainfrom
mjd507:redis-gateway
Apr 14, 2026
Merged

GH-8108: Add DSL for Redis Outbound Command Gateway.#10941
artembilan merged 2 commits into
spring-projects:mainfrom
mjd507:redis-gateway

Conversation

@mjd507

@mjd507 mjd507 commented Apr 13, 2026

Copy link
Copy Markdown
Contributor

Related to: #8108
@mjd507
spring-projectsGH-8108: Add DSL for Redis Outbound Command Gateway.
eebc4ca 
Related to: spring-projects#8108

Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
@artembilan artembilan added this to the 7.1.0-RC1 milestone Apr 13, 2026
artembilan
artembilan requested changes Apr 13, 2026
View reviewed changes

@artembilan artembilan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Just one suggestion.

Thanks
Comment thread src/reference/antora/modules/ROOT/pages/redis.adoc Outdated
@mjd507

mjd507 commented Apr 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Looks like a flaky failure on the Kafka batch inbound assertion. I try to amend this commit and force push.

Task :spring-integration-kafka:test

MessageDrivenAdapterTests > testInboundBatch(EmbeddedKafkaBroker) FAILED
java.lang.AssertionError at MessageDrivenAdapterTests.java:488
@mjd507
Add a user-friendly method named command(String) in `RedisOutboundG…
9cae4fc 
…atewaySpec`

Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
@artembilan

artembilan commented Apr 14, 2026

Copy link
Copy Markdown
Member

Thank you for the update, @mjd507 !

that Kafka batch test is indeed unstable .
I just cannot figure out properties combination to get exactly two records. Or we need to change test logic to verify until both records are there, or just drop such a test off 😢
@mjd507

mjd507 commented Apr 14, 2026

Copy link
Copy Markdown
Contributor Author

that Kafka batch test is indeed unstable . I just cannot figure out properties combination to get exactly two records. Or we need to change test logic to verify until both records are there, or just drop such a test off 😢

ok, I'll create an issue for that.
@artembilan
artembilan merged commit 9c01613 into spring-projects:main Apr 14, 2026
3 checks passed
@mjd507
mjd507 deleted the redis-gateway branch April 14, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment