Repository navigation
Conversation
🦋 Changeset detectedLatest commit: 8464557 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createStore()andcreateStore(undefined)start from an empty object in the browser, but on the server the state staysundefined, so the first partial update throws. The servercreateStorenow defaults the initial state to a fresh object, like the client. Supplied objects and arrays keep their identity and update behavior.How did you test this change?
packages/solid/test/server/store-default-state.spec.ts: 3 of its 5 tests fail without the change and all pass with it.pnpm buildandpnpm testpass (492 client and 23 server tests).undefinedand object initial values, then apply a partial update.