store zero element as a map of elements for each separate body - #908
Open
neryams wants to merge 3 commits into
Open
store zero element as a map of elements for each separate body#908neryams wants to merge 3 commits into
neryams wants to merge 3 commits into
Conversation
Member
|
@neryams Thanks for the PR! I know it is a lot to ask, but since there is no unit test file, would you mind creating one? A lot of the logic in this project is complex, and I want to make sure we add tests for new things. |
|
@rwwagner90 🛎️☝️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #907
I couldn't find any unit tests for the bounds file.