typing: allow Packet classes in Packet.fields_desc type hint - #5123
Open
jankesec wants to merge 1 commit into
Open
typing: allow Packet classes in Packet.fields_desc type hint#5123jankesec wants to merge 1 commit into
jankesec wants to merge 1 commit into
Conversation
Packet_metaclass explicitly supports and resolves references to Packet classes in fields_desc by inlining their fields_desc at class creation time. Update Packet.fields_desc type annotation from ClassVar[List[AnyField]] to ClassVar[List[Union[AnyField, Type[Packet]]]]. Fixes secdev#5018 AI-Assisted: yes (Antigravity)
jankesec
force-pushed
the
fix/fields-desc-type-hint
branch
from
September 1, 2026 11:22
7922ebb to
7edd8df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the type annotation of
Packet.fields_descto allow references toPacketclasses (subclasses), resolving #5018.Background
At runtime,
Packet_metaclass.__new__inscapy/base_classes.pyexplicitly resolves references to otherPacketsubclasses withinfields_descby inlining/flattening their fields:However,
Packet.fields_descwas typed only asClassVar[List[AnyField]], causing static type checkers to raise typing errors when referencing otherPacketclasses infields_desc.Changes
Packet.fields_desctype annotation inscapy/packet.pyfromClassVar[List[AnyField]]toClassVar[List[Union[AnyField, Type[Packet]]]].fields.uts).Fixes #5018