Add back more non-listener coverage for riverdatabasesql - #1368
Merged
Conversation
Small follow up to #1366 in which we add back non-listener test coverage for `riverdatabasesql`. In #1366 the driver tests replaced the non-listener driver initialization with the listener version which is probably largely okay since most code is going to get shared, but it's not a bad idea to also make sure the driver is fully operable without a listener.
bgentry
approved these changes
Aug 29, 2026
Contributor
Author
|
thx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small follow up to #1366 in which we add back non-listener test coverage
for
riverdatabasesql. In #1366 the driver tests replaced thenon-listener driver initialization with the listener version which is
probably largely okay since most code is going to get shared, but it's
not a bad idea to also make sure the driver is fully operable without a
listener.