fix Docs: add patch to CLI --version - #5220
Open
angelabenavente wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5173
The CLI looks up npm templates by exact version. Docs used the Docusaurus label (
0.86/0.87), soinit --version 0.86failed.getCurrentVersion()now returns a patch (0.87.0).Appending
.0in the snippet made Prism (bash) treat0.87as a number and.0as another token, so the version was two colors (screenshot of Highlight). The value is quoted (--version "0.87.0") so it highlights as one string. The CLI accepts that the same way.Screenshots
CLI (before ), command from the docs:
CLI (after),
--version "0.87.0"Docs (before), https://reactnative.dev/docs/turbo-native-modules-introduction
Highlight (without quotes),
--version 0.87.0Docs (after)
Affected pages
https://reactnative.dev/docs/turbo-native-modules-introduction
https://reactnative.dev/docs/the-new-architecture/using-codegen
https://reactnative.dev/docs/the-new-architecture/pure-cxx-modules
Issue
#5173