Fix bug in replica chunk acceptance when filters are used. #187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If osiris_replica:parse_chunk ended up parsing an chunk iolist where the first element in the list is exactly 48 bytes (the size of the osiris chunk header) it would end up crashing the call to osiris_log:accept_chunk as this assumed the filter data, when included, would always be in the first list element.
michaelklishin
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If osiris_replica:parse_chunk ended up parsing an chunk iolist where the first element in the list is exactly 48 bytes (the size of the osiris chunk header) it would end up crashing the call to osiris_log:accept_chunk as this assumed the filter data, when included, would always be in the first list element.