Skip to content

bpo-1635741: replace UCD_Check with Py_IS_TYPE - #22328

Merged
vstinner merged 2 commits into
python:masterfrom
koubaa:bpo-1635741-unicode-ucd-check
Sep 23, 2020
Merged

bpo-1635741: replace UCD_Check with Py_IS_TYPE#22328
vstinner merged 2 commits into
python:masterfrom
koubaa:bpo-1635741-unicode-ucd-check

Conversation

@koubaa

@koubaa koubaa commented Sep 20, 2020

Copy link
Copy Markdown
Contributor

First stage requested by @vstinner from #22145 - "Add a ucd_type parameter to UCD_Check() macro". Since this would make UCD_Check equivalent to Py_IS_TYPE, I instead converted to Py_IS_TYPE everywhere.

https://bugs.python.org/issue1635741

Comment thread Modules/unicodedata.c Outdated
@koubaa
koubaa force-pushed the bpo-1635741-unicode-ucd-check branch from 76bebb6 to c98bd9d Compare September 21, 2020 23:44
Comment thread Modules/unicodedata.c Outdated
Co-authored-by: Victor Stinner <vstinner@python.org>

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vstinner
vstinner merged commit ddc0dd0 into python:master Sep 23, 2020
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 24, 2020
* origin/master: (27 commits)
  bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388)
  bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387)
  bpo-41833: threading.Thread now uses the target name (pythonGH-22357)
  bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633)
  bpo-33822: Update IDLE section of What's New 3.8 (pythonGH-22383)
  bpo-41844: Add IDLE section to What's New 3.9 (GN-22382)
  bpo-41841: Prepare IDLE News for 3.10 (pythonGH-22379)
  bpo-37779 : Add information about the overriding behavior of ConfigParser.read (pythonGH-15177)
  bpo-40170: Use inline _PyType_HasFeature() function (pythonGH-22375)
  bpo-40941: Fix stackdepth compiler warnings (pythonGH-22377)
  bpo-40941: Fix fold_tuple_on_constants() compiler warnings (pythonGH-22378)
  bpo-40521: Fix PyUnicode_InternInPlace() (pythonGH-22376)
  bpo-41834: Remove _Py_CheckRecursionLimit variable (pythonGH-22359)
  bpo-1635741, unicodedata: add ucd_type parameter to UCD_Check() macro (pythonGH-22328)
  bpo-1635741: Port _lsprof extension to multi-phase init (PEP 489) (pythonGH-22220)
  bpo-41513: Improve order of adding fractional values. Improve variable names. (pythonGH-22368)
  bpo-41816: `StrEnum.__str__` is `str.__str__` (pythonGH-22362)
  bpo-35764: Rewrite the IDLE Calltips doc section  (pythonGH-22363)
  bpo-41810: Reintroduce `types.EllipsisType`, `.NoneType` & `.NotImplementedType` (pythonGH-22336)
  bpo-41602: raise SIGINT exit code on KeyboardInterrupt from pymain_run_module (python#21956)
  ...
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
@koubaa
koubaa deleted the bpo-1635741-unicode-ucd-check branch January 8, 2021 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

4 participants