bpo-1635741: port winapi to multi-stage init - #21371

Merged

vstinner merged 9 commits into

python:masterfrom

koubaa:bpo-1635741-winapi

Aug 13, 2020

koubaa commented Jul 7, 2020 •

edited by bedevere-bot

Loading

Contributor

https://bugs.python.org/issue1635741

the-knights-who-say-ni added the CLA signed label

koubaa changed the title ~~port winapi to multi-stage init~~

vstinner reviewed

View reviewed changes

vstinner left a comment

Member

cc @corona10 @shihai1991

Modules/_winapi.c Outdated

Modules/_winapi.c Outdated

Modules/_winapi.c Outdated

Modules/_winapi.c Outdated

vstinner reviewed

View reviewed changes

Modules/_winapi.c Outdated

shihai1991 reviewed

View reviewed changes

Modules/_winapi.c Outdated

vstinner reviewed

View reviewed changes

Modules/_winapi.c Outdated

vstinner reviewed

View reviewed changes

Modules/_winapi.c Outdated

Modules/_winapi.c Outdated

Modules/_winapi.c Outdated

Modules/_winapi.c Outdated

vstinner reviewed

View reviewed changes

Modules/_winapi.c Outdated

vstinner commented Jul 9, 2020

Member

continuous-integration/travis-ci Expected — Waiting for status to be reported
Required

Stupid CI. https://travis-ci.org/github/python/cpython/builds/706422141 ran and completed. But the status was not reported back to GitHub :-(

I restarted the build to try to work around the issue :-/

vstinner commented Jul 9, 2020

Member

I still see " continuous-integration/travis-ci Expected — Waiting for status to be reported ". Hum, I close/reopen the issue to force to re-run all CIs :-(

vstinner closed this

vstinner reopened this

vstinner commented Jul 9, 2020

Member

Right now, it's still " continuous-integration/travis-ci Expected — Waiting for status to be reported ". Silly CIs :-(

koubaa commented Aug 9, 2020

Contributor Author

@vstinner can this be merged?

vstinner reviewed

View reviewed changes

Modules/_winapi.c Outdated

vstinner commented Aug 10, 2020

Member

@corona10 @shihai1991: Would you mind to review this PR?

shihai1991 commented Aug 10, 2020 •

edited

Loading

Member

Hm, this ci gate skipped again, maybe we can fix it.

shihai1991 approved these changes

View reviewed changes

shihai1991 left a comment •

edited

Loading

Member

LGTM, I have no other comment in here.

bedevere-bot added the awaiting core review label

vstinner commented Aug 10, 2020

Member

Hm, this ci gate skipped again, maybe we can fix it.

koubaa closed this

koubaa reopened this

koubaa and others added 8 commits

August 13, 2020 07:30


          port winapi to multi-stage init

67c2350


          blurb

12c41c8


          reviewer suggestions

f5e2fc2


          fix refcount

283911c


          update based on review

e0e1b30


          update based on review


          update based on review

a836c71


          fix typo

af115c1


          check result of Py_BuildValue

42352a4

koubaa force-pushed the bpo-1635741-winapi branch from fce44d9 to 42352a4 Compare

August 13, 2020 12:30

koubaa commented Aug 13, 2020

Contributor Author

I just rebased it to reset the CI

vstinner merged commit e087f7c into python:master

bedevere-bot removed the awaiting core review label

vstinner commented Aug 13, 2020

Member

Thanks @koubaa, I merged your PR. Thanks @shihai1991 for the review.

shihai1991 pushed a commit to shihai1991/cpython that referenced this pull request


          bpo-1635741: Port _winapi ext to multi-stage init (pythonGH-21371)

1626edd

koubaa deleted the bpo-1635741-winapi branch

August 28, 2020 00:21

xzy3 pushed a commit to xzy3/cpython that referenced this pull request


          bpo-1635741: Port _winapi ext to multi-stage init (pythonGH-21371)

b89d2cd

kylotan mannequin mentioned this pull request

Py_Finalize() doesn't clear all Python objects at exit #44470

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment