[3.9] bpo-39791 native hooks for importlib.resources.files (GH-20576) - #20703
Merged
Conversation
* Provide native .files support on SourceFileLoader. * Add native importlib.resources.files() support to zipimporter. Remove fallback support. * make regen-all * 📜🤖 Added by blurb_it. * Move 'files' into the ResourceReader so it can carry the relevant module name context. * Create 'importlib.readers' module and add FileReader to it. * Add zip reader and rely on it for a TraversableResources object on zipimporter. * Remove TraversableAdapter, no longer needed. * Update blurb. * Replace backslashes with forward slashes. * Incorporate changes from importlib_metadata 2.0, finalizing the interface for extension via get_resource_reader. Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> (cherry picked from commit 843c277) Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
miss-islington
requested review from
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
June 8, 2020 01:01
jaraco
approved these changes
Jun 8, 2020
Contributor
Author
|
@jaraco: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@jaraco: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
@jaraco: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide native .files support on SourceFileLoader.
Add native importlib.resources.files() support to zipimporter. Remove fallback support.
make regen-all
📜🤖 Added by blurb_it.
Move 'files' into the ResourceReader so it can carry the relevant module name context.
Create 'importlib.readers' module and add FileReader to it.
Add zip reader and rely on it for a TraversableResources object on zipimporter.
Remove TraversableAdapter, no longer needed.
Update blurb.
Replace backslashes with forward slashes.
Incorporate changes from importlib_metadata 2.0, finalizing the interface for extension via get_resource_reader.
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
(cherry picked from commit 843c277)
Co-authored-by: Jason R. Coombs jaraco@jaraco.com
https://bugs.python.org/issue39791
Automerge-Triggered-By: @jaraco