Skip to content

bpo-39481: PEP 585 for a variety of modules - #19423

Merged
gvanrossum merged 3 commits into
python:masterfrom
isidentical:bpo-39481-group1
Apr 10, 2020
Merged

bpo-39481: PEP 585 for a variety of modules#19423
gvanrossum merged 3 commits into
python:masterfrom
isidentical:bpo-39481-group1

Conversation

@isidentical

@isidentical isidentical commented Apr 7, 2020 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member
  • queue.SimpleQueue
  • queue.Queue
  • tempfile.TemporaryDirectory
  • unittest.case._AssertRaisesContext

https://bugs.python.org/issue39481
@isidentical
isidentical requested a review from rhettinger as a code owner April 7, 2020 23:26
@isidentical
isidentical requested a review from gvanrossum April 7, 2020 23:26
emmatyping
emmatyping reviewed Apr 8, 2020
View reviewed changes
Comment thread Lib/test/test_genericalias.py Outdated
gvanrossum
gvanrossum approved these changes Apr 10, 2020
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once your other PR (#19418) lands you will have to rebase; then ping me and I'll land it.
Comment thread Lib/test/test_genericalias.py Outdated
@gvanrossum gvanrossum changed the title bpo-39481: Generic Alias for SimpleQueue, Queue, TemporaryDirectory... Apr 10, 2020
@gvanrossum gvanrossum closed this Apr 10, 2020
@gvanrossum gvanrossum reopened this Apr 10, 2020
This was referenced Apr 10, 2020
Closed
Closed
@isidentical

isidentical commented Apr 10, 2020

Copy link
Copy Markdown
Member Author

For preventing future conflicts, appending group2 and 3s into this PR.
@isidentical
isidentical requested a review from tiran as a code owner April 10, 2020 14:03
@isidentical
isidentical requested a review from gvanrossum April 10, 2020 14:04
@gvanrossum gvanrossum changed the title bpo-39481: PEP 585 for queue, tempfile, unittest Apr 10, 2020
@gvanrossum
gvanrossum merged commit 0361556 into python:master Apr 10, 2020
@cdce8p cdce8p mentioned this pull request May 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news

5 participants

@isidentical @gvanrossum @emmatyping @the-knights-who-say-ni @bedevere-bot