bpo-39638: Keep ASDL signatures in the AST nodes - #18515
Merged
Merged
Conversation
isidentical
force-pushed
the
bpo-39638
branch
3 times, most recently
from
February 15, 2020 20:10
83dffaf to
716f2e3
Compare
isidentical
marked this pull request as ready for review
February 22, 2020 16:26
serhiy-storchaka
self-requested a review
March 14, 2020 11:24
Member
|
Please resolve conflicts and update tests. |
1 similar comment
Member
|
Please resolve conflicts and update tests. |
isidentical
force-pushed
the
bpo-39638
branch
2 times, most recently
from
March 14, 2020 11:50
29d3cd5 to
ace16c9
Compare
Member
Author
|
Thanks for the ping, I updated the tests and rebased this PR to master. @serhiy-storchaka |
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
Member
There was a problem hiding this comment.
Very very nice! Added several suggestions.
isidentical
force-pushed
the
bpo-39638
branch
2 times, most recently
from
March 14, 2020 18:36
aafde35 to
90535cf
Compare
Member
|
Please regenerate Python-ast.c. |
Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>
Co-Authored-By: Serhiy Storchaka <storchaka@gmail.com>
Member
Author
|
@serhiy-storchaka done |
Member
|
Nice idea, great PR! |
colesbury
referenced
this pull request
in colesbury/nogil
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue39638