Skip to content

bpo-15786: IDLE: Fix autocomletetion mouse click and freeze behavior #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
louisom wants to merge 6 commits into from
Closed

bpo-15786: IDLE: Fix autocomletetion mouse click and freeze behavior #1517

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
94a66f0
bpo-15786: Fix autocomletetion box mouse behavior
louisom May 9, 2017
1da0c6a
Fix MacOS double click autocomplete box will freeze
louisom May 10, 2017
83081cd
Refactor comment issue number
louisom May 10, 2017
b70825b
Fix windows can't trigger double click event
louisom May 11, 2017
0d67829
Reuse acw in show_window
louisom May 11, 2017
1618206
Addressed terry suggestion
louisom May 11, 2017
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 27 additions & 7 deletions Lib/idlelib/autocomplete_w.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
"""
An auto-completion window for IDLE, used by the autocomplete extension
"""
import platform

from tkinter import *
from tkinter.ttk import Scrollbar

Expand Down Expand Up @@ -201,9 +203,10 @@ def show_window(self, comp_lists, index, complete, mode, userWantsWin):
self._selection_changed()

# bind events
self.hideid = self.widget.bind(HIDE_VIRTUAL_EVENT_NAME,
self.hide_event)
self.hideaid = acw.bind(HIDE_VIRTUAL_EVENT_NAME, self.hide_event)
self.hidewid = self.widget.bind(HIDE_VIRTUAL_EVENT_NAME, self.hide_event)
for seq in HIDE_SEQUENCES:
acw.event_add(HIDE_VIRTUAL_EVENT_NAME, seq)
self.widget.event_add(HIDE_VIRTUAL_EVENT_NAME, seq)
self.keypressid = self.widget.bind(KEYPRESS_VIRTUAL_EVENT_NAME,
self.keypress_event)
Expand Down Expand Up @@ -240,8 +243,18 @@ def winconfig_event(self, event):
new_y -= acw_height
acw.wm_geometry("+%d+%d" % (new_x, new_y))

if platform.system().startswith('Windows'):
# See issue 15786. When on windows platform, Tk will misbehaive
# to call winconfig_event multiple times, we need to prevent this,
# otherwise mouse button double click will not be able to used.
acw.unbind(WINCONFIG_SEQUENCE, self.winconfigid)
self.winconfigid = None

def hide_event(self, event):
if self.is_active():
# Hide autocomplete list if it exists and does not have focus
if (self.is_active() and
(self.widget == self.widget.focus_get() or
not self.widget.focus_get())):
self.hide_window()

def listselect_event(self, event):
Expand Down Expand Up @@ -392,9 +405,12 @@ def hide_window(self):

# unbind events
for seq in HIDE_SEQUENCES:
self.autocompletewindow.event_delete(HIDE_VIRTUAL_EVENT_NAME, seq)
self.widget.event_delete(HIDE_VIRTUAL_EVENT_NAME, seq)
self.widget.unbind(HIDE_VIRTUAL_EVENT_NAME, self.hideid)
self.hideid = None
self.autocompletewindow.unbind(HIDE_VIRTUAL_EVENT_NAME, self.hideaid)
self.widget.unbind(HIDE_VIRTUAL_EVENT_NAME, self.hidewid)
self.hideaid = None
self.hidewid = None
for seq in KEYPRESS_SEQUENCES:
self.widget.event_delete(KEYPRESS_VIRTUAL_EVENT_NAME, seq)
self.widget.unbind(KEYPRESS_VIRTUAL_EVENT_NAME, self.keypressid)
Expand All @@ -405,8 +421,12 @@ def hide_window(self):
self.keyreleaseid = None
self.listbox.unbind(LISTUPDATE_SEQUENCE, self.listupdateid)
self.listupdateid = None
self.autocompletewindow.unbind(WINCONFIG_SEQUENCE, self.winconfigid)
self.winconfigid = None
if self.winconfigid:
self.autocompletewindow.unbind(WINCONFIG_SEQUENCE, self.winconfigid)
self.winconfigid = None

# Re-focusOn frame.text (See issue #15786)
self.widget.focus_set()

# destroy widgets
self.scrollbar.destroy()
Expand Down