gh-132413: Clear weakref to _datetime after modules are finalized - #136152
Closed
neonene wants to merge 13 commits into
Closed
gh-132413: Clear weakref to _datetime after modules are finalized#136152neonene wants to merge 13 commits into
neonene wants to merge 13 commits into
Conversation
neonene
requested review from
ZeroIntensity,
abalkin,
ericsnowcurrently and
pganssle
as code owners
June 30, 2025 22:39
neonene
marked this pull request as draft
June 30, 2025 23:10
The given module can already be untracked.
neonene
marked this pull request as ready for review
July 1, 2025 20:00
Contributor
Author
|
A fundamental fix seems to be comming. |
neonene
marked this pull request as draft
July 2, 2025 18:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
_datetimemodule has a weakref to the module itself, which is expected to be connected all its life. However,finalize_remove_modules()inpylifecycle.cshares the same weakref, then the GC clears it before finishing the module.The module should be cleared first, bypassing the GC once.
datetime.timedelta(possibly from datetime's Cdelta_new) #132413