Set the Runner :timeout option to the maximum between itself and the :boot_timeout - #73
Open
probably-not wants to merge 1 commit into
Open
Set the Runner :timeout option to the maximum between itself and the :boot_timeout#73probably-not wants to merge 1 commit into
:timeout option to the maximum between itself and the :boot_timeout#73probably-not wants to merge 1 commit into
Conversation
That sounds like it's worth a mention in documentation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the
:timeoutand:boot_timeoutare separate options - however, when running something that has a long:boot_timeoutset, you must know to set the:timeoutoption to the same time (or longer), otherwise, theFLAME.callfunction calls will fail with a timeout even if the boot has not completed.This PR sets the
:timeoutoption to be the maximum between the:timeoutand the:boot_timeout, to ensure that a timeout cannot happen before a boot_timeout happens.