Merged
Conversation
Owner
|
Interesting. I will look closer and update next beta with fix. let's see if its help |
Contributor
Author
|
@overtake can't reproduce the issue in the new 9.3 beta. Some changes from your side? |
Owner
Yes. I've implemented your fix. So, if there is no more issue i merge your pull request. Thank you. |
Owner
|
i will figure out later how to fix this issue properly =) |
Farxod19720202
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is an issue with MediaPlayer.
We have at least 3 bug reports that covers that:
https://bugs.telegram.org/c/20486
https://bugs.telegram.org/c/21311
#892
Personally I like description of this one.
But in general when the video ends or when you rewind it, there is a chance that all videos stops to play (until you restart the app) or the main thread deadlocks (app just hangs) and you need to restart the application.
It's easy to reproduce on Macbook with 2,4 GHz 8-Core Intel Core i9. But I couldn't reproduce it on Macbook Air with 2 slow cores.
The reason of that behaviour is deadlock that occurs when using some CoreMedia components (from my observation CM clock or time related functions, like
CMAudioDeviceClockCreate).I made an assumption that this can occur because of the race condition when we create MediaPlayerAudioRenderer. So we creating it from
playerQueuequeue and there is a chance that inaudioPlayerRendererQueuethere are still tasks related to cleaning up of the previous object. So we need to wait until all cleaning happens and then create required objects.With suggested changes I couldn't reproduce the issue.
Let me know if you need more details, I can provide threads stacktrace with deadlock, or video to reproduce this bug.