Update chat controller sidebar UI on appearance#3
Open
timaktimak wants to merge 3 commits intoovertake:masterfrom
Open
Update chat controller sidebar UI on appearance#3timaktimak wants to merge 3 commits intoovertake:masterfrom
timaktimak wants to merge 3 commits intoovertake:masterfrom
Conversation
Owner
|
no so fast. sidebar is really pain for performance and other bug, please test it for all cases |
|
|
overtake
pushed a commit
that referenced
this pull request
Mar 25, 2020
overtake
pushed a commit
that referenced
this pull request
Mar 25, 2020
overtake
pushed a commit
that referenced
this pull request
Mar 25, 2020
overtake
pushed a commit
that referenced
this pull request
Mar 25, 2020
overtake
pushed a commit
that referenced
this pull request
Mar 25, 2020
overtake
pushed a commit
that referenced
this pull request
Mar 25, 2020
overtake
pushed a commit
that referenced
this pull request
Mar 25, 2020
overtake
pushed a commit
that referenced
this pull request
Mar 25, 2020
overtake
pushed a commit
that referenced
this pull request
Mar 25, 2020
overtake
pushed a commit
that referenced
this pull request
Mar 25, 2020
overtake
force-pushed
the
master
branch
3 times, most recently
from
9aa8690 to
579cebb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After toggling the sidebar setting, the user had to select a new chat to see the setting being applied. Now the sidebar is shown/hidden right after the chat controller is back on the screen.