Fix emoji search using keyboard language instead of system language#1252
Closed
anperez wants to merge 0 commit intoovertake:masterfrom
Closed
Fix emoji search using keyboard language instead of system language#1252anperez wants to merge 0 commit intoovertake:masterfrom
anperez wants to merge 0 commit intoovertake:masterfrom
Conversation
|
|
|
@overtake could we give this some love please? |
|
@overtake can we please get this PR rebased/merged to baseline for the next release? It makes my life a living hell 🤕 |
|
Ping @overtake could we please merge this? 😭 |
overtake
force-pushed
the
master
branch
3 times, most recently
from
9aa8690 to
579cebb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts a change to
InputSources.swiftintroduced in 4fabc33 that made emoji search depend on the current keyboard layout (e.g., Spanish), rather than the system language (e.g., English).This restores the previous behavior by using
currentAppInputSource().uniqueElementsinstead ofcurrentKeyboardLanguage(), ensuring emoji search results align with the system language preferences.This should fix #1200
EDIT:⚠️ Closed accidentally while sync'ing branches. Re-opened as #1301 ⚠️