Repository navigation
Conversation
Both arguments were declared with useDefaultForNone, so an explicit None was replaced by the default and count(None) and count(0, None) returned count(0). CPython requires a number for any argument that is passed and raises TypeError for None. Signed-off-by: Jeongseop Lim <jeongseop_lim@korea.ac.kr>
oracle-contributor-agreement
Bot
added
the
OCA Verified
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1251
CountNodedeclaredstartandstepwithuseDefaultForNone = true, so an explicitNonewas replaced by the default before the number check. CPython defaults only an omitted argument and rejectsNoneinitertools_count_impl(itertoolsmodule.c#L4022-L4026).AS-IS
TO-BE
(matching CPython)
Changes
useDefaultForNone = truefrom thestartandstepannotations ofCountNode, so the defaults apply only to an omitted argument.tests/test_itertools_count.py.Testing
mx python-jvmon darwin-aarch64, then the newtest_itertools_count.py(3 passed) and the taggedtest_itertools(124 passed). The new test fails on the unpatched build.count(),count(5),count(1.5, 2)andcount(step=2)print the same as before, andcount(start=None)now raisesTypeErrorlike CPython 3.13.14.