Skip to content

Fix nvml type clash with latest nv-codec-headers - #14075

Open
BtbN wants to merge 1 commit into
obsproject:masterfrom
BtbN:fix-ffnvcodec-nvml-clash
Open

BtbN wants to merge 1 commit into
obsproject:masterfrom
BtbN:fix-ffnvcodec-nvml-clash

Conversation

@BtbN

@BtbN BtbN commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Description

Fix nvml type clash with latest nv-codec-headers
It defines the return type as enum, not int, and has a high chance to clash in general cause it tries to achieve the same thing.

Motivation and Context

Build error with latest headers.

How Has This Been Tested?

Builds fine again with this change.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.
@Fenrirthviti

Copy link
Copy Markdown
Member

Please properly fill out the PR template.

@tytan652 tytan652 added the area/dependency Issue is in external library or dependency, not OBS itself label Oct 24, 2026
@BtbN

BtbN commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

Weird, GitHub did not present me with one when opening the PR.
I also don't immediately see a template in the usual paths in the repo, so I just copied it from another PR now.

This makes the headers skip defining any NVML types, and is otherwise inconsequential.
@BtbN
BtbN force-pushed the fix-ffnvcodec-nvml-clash branch from 86bf5c2 to 55eff4e Compare October 24, 2026 17:29
@Fenrirthviti

Copy link
Copy Markdown
Member

Very odd, it should be for all PRs. For reference, we have a project-wide template, which is housed here: https://github.com/obsproject/.github

Formatting was a bit wonky on your copy, fixed it.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dependency Issue is in external library or dependency, not OBS itself

4 participants