Skip to content

Record that a green local rig run can mean half the rig never ran - #403

Open
nyblnet wants to merge 1 commit into
mainfrom
docs-half-a-rig
Open

Record that a green local rig run can mean half the rig never ran#403
nyblnet wants to merge 1 commit into
mainfrom
docs-half-a-rig

Conversation

@nyblnet

@nyblnet nyblnet commented Aug 29, 2026

Copy link
Copy Markdown
Owner

Docs only — one entry appended to docs/DECISIONS.md.

The finding. scripts/test-sanitize.ts has a node half (pure functions,
runs anywhere) and a browser half (drives real Chrome, because what it tests
needs a DOM). With no Chrome, the browser half says so, skips, and the run
still ends green.

sanitizeSvg needs a DOM, so it is covered only by the browser half. That is
how a change to it passed five rigs locally and was caught by CI a minute later
with ✗ the svg <style> is kept (#402).

The rule: not "run the rigs" but run the rig that covers the file you
edited, and check which half of it ran. Not how many passed — which ones.

It belongs with the instrument-lies family this log already collects: a CSS
transform on an inline element that reads back verbatim and moves zero pixels,
document.fonts.check() returning true for an uninstalled font, rAF throttled
to zero in a hidden tab, an SVG rasteriser ignoring font-family.

The correction is the point. I first filed this as "sanitizeSvg has no rig
coverage" — false. The coverage exists and works. "Your green local run may have
skipped it" is true and actionable; "there is no coverage" would have sent
someone to write a rig that already exists.

Raised by bento-team-lead, who suggested promoting it rather than leaving it
in the zone notes.

Note on scope: docs/ is scribe's zone, but the session ritual asks every
zone to promote durable findings to DECISIONS.md, and this is append-only —
no existing entry touched. Deliberately NOT touching root CHANGELOG.md, which
is scribe's and has #400 open on it.

Checklist

  • Docs only — no code, no format change, no version bump
  • Append-only; conflicts with other in-flight DECISIONS.md entries are a rebase, not a merge decision
@github-actions

github-actions Bot commented Aug 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Build size

main (7422f4f) → docs-half-a-rig (bc3c361)

app base PR change
bento/slides 669.3 KiB 669.3 KiB 0.0 KiB (0.00%)
bento/spaces 267.6 KiB 267.6 KiB 0.0 KiB (0.00%)
bento/dash 161.3 KiB 161.3 KiB 0.0 KiB (0.00%)

Updated: 2026-08-30T19:15:05Z
nyblnet @nyblnet
Record that a green local rig run can mean half the rig never ran
bc3c361 
test-sanitize.ts has a node half and a browser half. The browser half
needs Chrome, says so when there is none, skips, and the run still ends
green. sanitizeSvg needs a DOM, so it is covered ONLY by that half --
which is how a change to it passed five rigs locally and was caught by CI
a minute later.

The rule worth keeping is not "run the rigs" but "run the rig that covers
the file you edited, and check WHICH HALF ran". A skip that prints like a
pass belongs with the instruments this log already collects: the CSS
transform on an inline element that reads back correctly and moves
nothing, document.fonts.check() returning true for a missing font, rAF
throttled to zero in a hidden tab.

Filed first as "sanitizeSvg has no rig coverage", which was false. The
correction is the useful artifact: "there is no coverage" would have sent
someone to write a rig that already exists and works.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@nyblnet