test: allow leaked global check to be skipped - #27239
Closed
cjihrig wants to merge 1 commit into
Closed
Conversation
This simplifies the process of running tests on different versions of Node, which might have a different set of global variables.
nodejs-github-bot
added
the
test
Collaborator
Contributor
Author
|
cc: @Trott |
Trott
approved these changes
Apr 15, 2019
Trott
left a comment
Trott
left a comment
Member
There was a problem hiding this comment.
LGTM. Nit: Probably worth adding a note to test/common/README.md about it?
BridgeAR
approved these changes
Apr 15, 2019
BridgeAR
added
the
author ready
Collaborator
addaleax
approved these changes
Apr 15, 2019
lpinca
approved these changes
Apr 15, 2019
Collaborator
jasnell
approved these changes
Apr 17, 2019
Contributor
|
Landed in 57ab3b5. |
danbev
pushed a commit
that referenced
this pull request
Apr 19, 2019
This simplifies the process of running tests on different versions of Node, which might have a different set of global variables. PR-URL: #27239 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 23, 2019
kt3k
reviewed
Mar 18, 2025
| if (process.env.NODE_TEST_KNOWN_GLOBALS !== '0') { | ||
| if (process.env.NODE_TEST_KNOWN_GLOBALS) { | ||
| const knownFromEnv = process.env.NODE_TEST_KNOWN_GLOBALS.split(','); | ||
| allowGlobals(...knownFromEnv); |
Contributor
There was a problem hiding this comment.
Shouldn't this be something like:
allowGlobals(...knownFromEnv.map((name) => globalThis[name]));
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the process of running tests on different versions of Node, which might have a different set of global variables.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes