Avoid needless CTest targets - #2776
Open
scivision wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the top-level CMake configuration to avoid generating unnecessary CTest/CDash-related build targets by switching away from include(CTest) and enabling testing more narrowly.
Changes:
- Replace
include(CTest)usage withenable_testing()underif(BUILD_TESTING). - Modernize the perf-test loop to use
foreach(... IN ITEMS ...).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
use enable_testing() to avoid spurious test targets, as we aren't using CDash or those targets
Collaborator
|
I don't understand this, sorry. Can you elaborate why this is an improvement? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use enable_testing() to avoid spurious test targets, as we aren't using CDash or those targets