Skip to content

Add PhotoKit background uploads for Auto Upload on iOS 27 & NC >= 33 - #4279

Draft
marinofaggiana wants to merge 36 commits into
masterfrom
3838-autoupload-investigate-ios27-background-uploader---photokit
Draft

Add PhotoKit background uploads for Auto Upload on iOS 27 & NC >= 33#4279
marinofaggiana wants to merge 36 commits into
masterfrom
3838-autoupload-investigate-ios27-background-uploader---photokit

Conversation

@marinofaggiana

@marinofaggiana marinofaggiana commented Sep 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Summary

Introduces the iOS 27 PhotoKit Background Resource Upload extension for Nextcloud Auto Upload.

The new implementation:

  • delegates uploads to PhotoKit using PHAssetResourceUploadJob;
  • creates and tracks upload jobs through Realm metadata;
  • builds authenticated WebDAV PUT destinations;
  • processes successful uploads and Nextcloud response headers;
  • retries temporary failures without a retry limit;
  • stops retries for authentication failures;
  • cancels or acknowledges jobs whose metadata was deleted;
  • limits the active upload window to 20 jobs;
  • prevents PhotoKit jobs from entering the legacy upload pipeline;
  • supports one Auto Upload account with a Nextcloud server version of 33 or newer;
  • falls back to the legacy Auto Upload implementation when the extension requirements are not met.

Live Photo handling is intentionally excluded and will be addressed separately.

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI
@marinofaggiana
feat: add Photos background upload extension
c83905f 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
feat: enable background photo upload extension
8fec657 
Request full photo library access at launch and enable the upload job extension on iOS 27.

Use OSLog for background upload lifecycle events.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
feat: embed background upload extension
5bfe6ce 
Add a shared extension scheme and diagnostic lifecycle logging.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
test
f2af31e 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: disable auto upload on iOS 27
813bab1 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
feat: acknowledge background photo upload jobs
945f1f7 
Store background upload job identifiers in metadata and bump the database schema version.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
test
0c49ab7 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
lib
5cbc4fa 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
feat: enable database access in background upload extension
c512b05 
Add Realm-backed metadata support and build upload destination requests in the background upload target.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
refactor: move background upload configuration to Brand
61cd561 
Update the extension project settings to use the relocated entitlements and property list files.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
feat: complete background upload job lifecycle
0c46437 
Create, retry, and acknowledge Photos background upload jobs while syncing their results to metadata.

Exclude extension-managed uploads from the legacy networking process.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
feat: delegate auto uploads to Photos extension
2b63aed 
Enable the upload job extension for eligible accounts and fall back to the existing auto-upload flow when unavailable.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
feat: set up accounts for background uploads
b873487 
Initialize the extension database, logger, and NextcloudKit sessions, and split account-related metadata handling into dedicated extension files.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
refactor: split background upload extension workflows
ea4be8d 
Move destination, job, and result handling into focused extension files and add retry processing for background upload jobs.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
cleaning
09206cd 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
refactor: clean up background upload extension code
4b83071 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
feat: queue assets for background auto upload
7124eab 
Track completed auto-upload transfers and clear job identifiers only after successful acknowledgement.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: handle orphaned background upload jobs
903eb1e 
Acknowledge jobs without metadata and mark successful uploads with a missing file ID as errors.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
refactor: extract background upload discovery
c33b076 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
lint
fc53dcd 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: honor network settings for background uploads
fa8d944 
Require server version 33 or later and update the upload extension options when already enabled.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: respect account settings for background auto uploads
723a79e 
Use account-specific subfolder granularity when creating upload paths and only skip assets by their generated filename.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: harden background upload job processing
d3127ec 
Scope pending uploads to active accounts, acknowledge orphan retry jobs, preserve asset dimensions and size, and accept standard ETag headers.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
feat: persist background upload retry state
2c1ac99 
Bump the Realm database schema version to 416.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: register metadata tags in background upload database
b6f4c0e 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: respect background upload job capacity
ae9b60e 
Limit pending metadata creation to available upload slots and prevent duplicate asset queuing by local identifier.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: limit auto upload to one account
e1b9050 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: coordinate auto-upload account switching and job cancellation
694286a 
Restrict auto-upload processing to the active account and delegate supported flows to the Photos extension.

Cancel or acknowledge background jobs when auto-upload is disabled or moved to another account.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: retry failed background upload jobs
d94bf59 
Reset retry state after successful uploads and preserve session data when handling failures.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
capabilities fix
3add952 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
lint
9168fc4 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: enable background uploads after date changes
6ad8252 
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: disable background upload extension when idle
cf67ba0 
Defer disabling until active auto-upload jobs finish and cap concurrent extension jobs at 20.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana
fix: handle background upload authentication failures
9f84fd4 
Acknowledge orphaned jobs, stop retrying authentication failures, and keep processing active while upload jobs remain.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana marinofaggiana self-assigned this Sep 1, 2026
@marinofaggiana marinofaggiana linked an issue Sep 1, 2026 that may be closed by this pull request
Autoupload: Investigate iOS27 background uploader - PhotoKit #3838
Open
@marinofaggiana
marinofaggiana marked this pull request as draft September 1, 2026 09:16
@marinofaggiana marinofaggiana changed the title 3838 autoupload investigate ios27 background uploader photokit Sep 1, 2026
@marinofaggiana
fix: handle background upload cancellation
c0736d8 
Delete pending uploads immediately and mark active background uploads for cancellation.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
@marinofaggiana marinofaggiana changed the title Add PhotoKit background uploads for Auto Upload on iOS 27 Sep 1, 2026
@marinofaggiana
refactor: improve background upload extension logging
182c63d 
Use OSLog levels for extension diagnostics while persisting errors and key lifecycle events. Update the Nextcloud scheme to prompt for the app when debugging extensions.

Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@marinofaggiana