Skip to content

fix(fab): state - #17913

Open
alperozturk96 wants to merge 3 commits into
masterfrom
fix/fab-state
Open

fix(fab): state#17913
alperozturk96 wants to merge 3 commits into
masterfrom
fix/fab-state

Conversation

@alperozturk96

@alperozturk96 alperozturk96 commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Issues

When user navigates to shared root then open shared folder then presses back FAB becomes visible.

Changes

  • FAB state consolidated and handled from one place.

Expected behaviour

  • All files root - Visible
  • Any sub folder from any root All files, shared, favorites - Visible
  • Shared and Favorite root - Not Visible
  • File/Folder Detail - Not Visible
  • Media - Not Visible
  • If folder read only - Grayed out
@github-actions

github-actions Bot commented Oct 30, 2026 •
edited
Loading

Copy link
Copy Markdown

📱 QA build
Download app-qa-debug.apk
QR code Open the QR code for this download
Commit 3a82580
Version 17913
Available until 7 days after this build

The QA build installs alongside a released Nextcloud app, so you can keep
using your existing install while testing.

Downloading the file requires a GitHub account, so open this link on the
device you want to test on, or transfer the APK to it.
@codecov

codecov Bot commented Oct 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 38.23529% with 21 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...owncloud/android/ui/fragment/OCFileListFragment.kt 21.42% 6 Missing and 5 partials ⚠️
.../java/com/owncloud/android/ui/fragment/FabState.kt 66.66% 0 Missing and 5 partials ⚠️
...d/ui/fragment/OCFileListMultiChoiceModeListener.kt 0.00% 2 Missing ⚠️
...wncloud/android/ui/activity/FileDisplayActivity.kt 0.00% 1 Missing ⚠️
...ncloud/android/ui/fragment/ExtendedListFragment.kt 0.00% 1 Missing ⚠️
...om/owncloud/android/ui/fragment/GalleryFragment.kt 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!
@alperozturk96 alperozturk96 added this to the Nextcloud App 35.1.0 milestone Oct 30, 2026
@alperozturk96
unify fab state logic
232fa2e 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>

# Conflicts:
#	app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.kt
@alperozturk96
move logic inside enum
cfb75c6 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@alperozturk96
wip
3a82580 
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
@github-actions

github-actions Bot commented Oct 30, 2026

Copy link
Copy Markdown

SpotBugs

CategoryBaseNew
Bad practice2424
Correctness4545
Dodgy code146146
Experimental11
Malicious code vulnerability11
Multithreaded correctness1818
Performance2828
Security1515
Total278278
@github-actions

github-actions Bot commented Oct 30, 2026

Copy link
Copy Markdown

stable22-IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/17913-IT-stable22-10-57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review

1 participant

@alperozturk96