Skip to content

[code-infra] Share react-window version through the docs catalog - #49622

Open
LukasTy wants to merge 3 commits into
mui:masterfrom
LukasTy:claude/duplicate-dep-lock-file-45fda4
Open

LukasTy wants to merge 3 commits into
mui:masterfrom
LukasTy:claude/duplicate-dep-lock-file-45fda4

Conversation

@LukasTy

@LukasTy LukasTy commented Oct 30, 2026

Copy link
Copy Markdown
Member

Renovate sends docs dependencies and test devDependencies to separate PRs. This can put two react-window versions in the lockfile, for example in #49570.

This PR adds react-window to catalogs.docs. Both packages now use catalog:docs, so Renovate has one version source to update. The resolved version stays 2.3.4.

test no longer has an exact pin. The lockfile fixes the exact version.

Generated with Claude Code

LukasTy and others added 2 commits October 30, 2026 15:48
Renovate sends docs dependencies and test devDependencies to separate PRs, which can put two react-window versions in the lockfile. A catalog entry gives both packages one version source.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@LukasTy LukasTy added the scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). label Oct 30, 2026
@code-infra-dashboard

code-infra-dashboard Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Deploy preview

https://deploy-preview-49622--material-ui.netlify.app/
QR code for https://deploy-preview-49622--material-ui.netlify.app/

Bundle size

Bundle Parsed size Gzip size
@mui/material 0B(0.00%) 0B(0.00%)
@mui/lab 0B(0.00%) 0B(0.00%)
@mui/private-theming 0B(0.00%) 0B(0.00%)
@mui/system 0B(0.00%) 0B(0.00%)
@mui/utils 0B(0.00%) 0B(0.00%)

Details of bundle changes

Performance

No regressions in 32 benchmarks · ran 3m 35s · details


Check out the code infra dashboard for more information about this PR.

@LukasTy LukasTy added the type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature. label Oct 30, 2026
@LukasTy
LukasTy marked this pull request as ready for review October 30, 2026 14:09
@LukasTy
LukasTy requested review from Janpot and brijeshb42 October 30, 2026 14:09
Comment thread pnpm-workspace.yaml
'@emotion/server': '^11.11.0'
'@emotion/styled': '^11.14.1'
'@mui/internal-docs-infra': '0.13.1-canary.19'
react-window: '^2.3.4'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have a separate docs catalog and not a repo wide one?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs catalog shares same dep versions for docs and core-docs packages.
I did this during the removal of mui/monorepo dependency.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still needed? Shouldn't we rather have 1 catalog for everything?

@github-actions github-actions Bot added the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 30, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged. label Oct 30, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope: code-infra Involves the code-infra product (https://www.notion.so/mui-org/5562c14178aa42af97bc1fa5114000cd). type: enhancement It’s an improvement, but we can’t make up our mind whether it's a bug fix or a new feature.

3 participants