Repository navigation
Conversation
Deploy previewBundle size
PerformanceNo regressions in 32 benchmarks · ran 4m 14s · details Check out the code infra dashboard for more information about this PR. |
Author
|
The required-label check is failing because the PR has no label yet. I cannot apply labels from a fork; |
DiegoAndai
requested review from
aarongarciah
and removed request for
DiegoAndai
October 27, 2026 15:28
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #49547.
The default Chip avatar used grey text that fell below the 4.5:1 minimum against its background in both light and dark modes. This changes the avatar text to black or white, including the corresponding CSS variable tokens, and adds computed-style contrast tests for both theme paths.
Tests:
pnpm test:unit run packages/mui-material/src/Chip/Chip.test.jspnpm test:browser run packages/mui-material/src/Chip/Chip.test.jspnpm exec eslint packages/mui-material/src/Chip/Chip.js packages/mui-material/src/Chip/Chip.test.js packages/mui-material/src/styles/createThemeWithVars.jspnpm exec prettier --check packages/mui-material/src/Chip/Chip.js packages/mui-material/src/Chip/Chip.test.js packages/mui-material/src/styles/createThemeWithVars.js