Add uniformEffect for GPU bindings - #3800
Open
mattgperry wants to merge 4 commits into
Open
Conversation
Bind MotionValues to uniform setters while batching GPU writes before the render step. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep GPU integrations out of the main bundle while supporting both vgpu setter bags and Three.js uniform objects. Co-authored-by: Cursor <cursoragent@cursor.com>
Let vgpu and Three.js subjects animate through their registered MotionValues, with Three.js dispatching between uniform and object effects. Co-authored-by: Cursor <cursoragent@cursor.com>
Allow Three.js targets to animate directly and let vgpu uniforms animate from explicit keyframes without requiring prior effect registration. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uniformEffectadapter for binding MotionValues to GPU uniform setterspreRender, including across multiple bindings on the same subjectmotion-domand cover batching, ordering, and cleanupTest plan
motion-domJest suite (514 passing)motion-dommotion-domand validate its bundleMade with Cursor