Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
Closing an SDK agent stream after consuming a chunk currently closes only the outer async generator. Python's
async fordoes not automatically close the iterator it consumes. As a result, the nested retry/step/model generators remain suspended: the HTTP model stream stays open andrun_loop's existing interrupted-round persistence is deferred to eventual async-generator finalization.Use
contextlib.aclosingat the three ownership boundaries (run(stream=True)→run_loop→ retriedstep) so explicit consumer shutdown reaches the model stream beforeaclose()returns. This does not change retries, payloads, or normal streaming output.Validation
step,run_loop, and the publicrun(stream=True)against a real OpenAI-compatible SDK stream usinghttpx.MockTransport. All three failed on the base (model stream outlived its consumer), and pass after the fix; run-loop/public-run cases also verify interrupted-round persistence is invoked.pytest -q tests/utils/test_retry_classification.py tests/agent/test_llm_io.py tests/agent/test_partial_round.py: 59 passed, 15 skipped.git diff --check: passed.Not tested: live providers, a full initialized tool/MCP session, the entire repository suite, or other Python versions. Optional Anthropic cases were skipped because its dependency is not installed. Tests use the real stream/agent loop with unrelated setup mocked; these are local results, not upstream CI.
AI assistance
Implementation and automated verification were performed with OpenAI Codex. No human-review attestation is made.