Repository navigation
Conversation
…tablished on shutdown processPendingDiscoveryEvents() was inadvertently moved out of the private status(boolean) in MODCLUSTER-103, so init()'s status(false) iterates an empty proxy list and never establishes a connection. Restore the drain call before status(false) so statically configured proxies are contacted eagerly during init. Also reset both established flags on shutdown so isEstablished() does not report a stale value after stop. Signed-off-by: Radoslav Husar <rhusar@ibm.com>
rhusar
marked this pull request as draft
September 3, 2026 09:33
rhusar
marked this pull request as ready for review
October 8, 2026 16:08
jajik
approved these changes
Oct 12, 2026
jajik
left a comment
jajik
left a comment
Member
There was a problem hiding this comment.
This looks sensible to me. But it's a little bit weird, frankly.
rhusar
marked this pull request as draft
October 12, 2026 15:25
Member
Author
|
Thanks @jajik but I ll move this back to draft -- we first need to address the proxy state handling design issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The processPendingDiscoveryEvents() was inadvertently moved out of the private status(boolean) in MODCLUSTER-103, so init()'s status(false) iterates an empty proxy list and never establishes a connection. Restore the drain call before status(false) so statically configured proxies are contacted eagerly during init.
Also reset both established flags on shutdown so isEstablished() does not report a stale value after stop.
This would fix registration with the proxies in init.
https://redhat.atlassian.net/browse/MODCLUSTER-876